Fixes missing reference for claim #3309
Merged
+7
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the form is invalid, say the journey session has already been submitted and the user double clicks the submit button, we need to return early from the child `save` method to avoid calling the mailer with a claim that hasn't been saved (which triggeres an error as the claim has no reference number).
alkesh
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the form is invalid, say the journey session has already been
submitted and the user double clicks the submit button, we need to
return early from the child
savemethod to avoid calling the mailerwith a claim that hasn't been saved (which triggeres an error as the
claim has no reference number).